]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: octeontx - Replace scnprintf with strscpy in print_ucode_info
authorThorsten Blum <thorsten.blum@linux.dev>
Mon, 2 Feb 2026 17:33:21 +0000 (18:33 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 28 Feb 2026 03:53:58 +0000 (12:53 +0900)
Replace scnprintf("%s", ...) with the faster and more direct strscpy().
Remove the parentheses while we're at it.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c

index 09e6a8474d1abce4ce26bdf272435d6fd7a306fc..e0f38d32bc935b674f1a40759d79a480b575eb41 100644 (file)
@@ -10,6 +10,7 @@
 
 #include <linux/ctype.h>
 #include <linux/firmware.h>
+#include <linux/string.h>
 #include <linux/string_choices.h>
 #include "otx_cpt_common.h"
 #include "otx_cptpf_ucode.h"
@@ -509,13 +510,12 @@ EXPORT_SYMBOL_GPL(otx_cpt_uc_supports_eng_type);
 static void print_ucode_info(struct otx_cpt_eng_grp_info *eng_grp,
                             char *buf, int size)
 {
-       if (eng_grp->mirror.is_ena) {
+       if (eng_grp->mirror.is_ena)
                scnprintf(buf, size, "%s (shared with engine_group%d)",
                          eng_grp->g->grp[eng_grp->mirror.idx].ucode[0].ver_str,
                          eng_grp->mirror.idx);
-       } else {
-               scnprintf(buf, size, "%s", eng_grp->ucode[0].ver_str);
-       }
+       else
+               strscpy(buf, eng_grp->ucode[0].ver_str, size);
 }
 
 static void print_engs_info(struct otx_cpt_eng_grp_info *eng_grp,