Bug 285532: GetSelectableProducts cannot run on PostgreSQL when classifications are...

Patch By Max Kanat-Alexander <mkanat@kerio.com> r=Tomas.Kopal, a=justdave

diff --git a/globals.pl b/globals.pl
index 44bf7dc3ea33fa53ee3b529f31e95103c83450f0..53119c0342aa2a3911deba9800a8b99df4636a60 100644 (file)
--- a/globals.pl
+++ b/globals.pl
@@ -509,7 +509,8 @@ sub GetSelectableProducts {
 
     my $extra_sql = $by_id ? "id, " : "";
 
-    my $extra_from_sql = $by_classification ? ", classifications" : "";
+    my $extra_from_sql = $by_classification ? " INNER JOIN classifications"
+        . " ON classifications.id = products.classification_id" : "";
 
     my $query = "SELECT $extra_sql products.name " .
                 "FROM products $extra_from_sql " .
@@ -527,7 +528,6 @@ sub GetSelectableProducts {
     }
     $query .= "WHERE group_id IS NULL ";
     if ($by_classification) {
-        $query .= "AND classifications.id = products.classification_id ";
         $query .= "AND classifications.name = ";
         $query .= SqlQuote($by_classification) . " ";
     }