]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
src/node_device: don't overwrite error messages
authorDaniel P. Berrangé <berrange@redhat.com>
Tue, 7 May 2024 13:35:39 +0000 (14:35 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Wed, 8 May 2024 15:01:34 +0000 (16:01 +0100)
The nodedev code unhelpfully reports

  couldn't convert node device def to mdevctl JSON

which hides the actual error message

  No JSON parser implementation is available

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/node_device/node_device_driver.c

index d99b48138ebf079240ed95fce1724213cbbbe06a..700776c90c35bd8bfca3fce9593874e210e7accc 100644 (file)
@@ -774,8 +774,6 @@ nodeDeviceGetMdevctlCommand(virNodeDeviceDef *def,
         }
 
         if (nodeDeviceDefToMdevctlConfig(def, &inbuf, true) < 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                           _("couldn't convert node device def to mdevctl JSON"));
             return NULL;
         }