]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: hda: Remove old commented out sanity check
authorThorsten Blum <thorsten.blum@linux.dev>
Thu, 3 Jul 2025 22:52:36 +0000 (00:52 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 4 Jul 2025 07:08:45 +0000 (09:08 +0200)
The sanity check has been commented out for more than 12 years since
commit d5657ec9f4ad ("ALSA: hda - Disable the sanity check in
snd_hda_add_pincfg()") - remove it.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20250703225238.308359-2-thorsten.blum@linux.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_codec.c

index 5508381a183321da12aff3a315e0ee5c149d9f23..cb72e9655c8a62db624cd53b51f8128eb830391e 100644 (file)
@@ -479,15 +479,6 @@ int snd_hda_add_pincfg(struct hda_codec *codec, struct snd_array *list,
 {
        struct hda_pincfg *pin;
 
-       /* the check below may be invalid when pins are added by a fixup
-        * dynamically (e.g. via snd_hda_codec_update_widgets()), so disabled
-        * for now
-        */
-       /*
-       if (get_wcaps_type(get_wcaps(codec, nid)) != AC_WID_PIN)
-               return -EINVAL;
-       */
-
        pin = look_up_pincfg(codec, list, nid);
        if (!pin) {
                pin = snd_array_new(list);