]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
Add comment what the effect of calling the qname-minimization
authorOtto Moerbeek <otto.moerbeek@open-xchange.com>
Mon, 10 Aug 2020 11:36:15 +0000 (13:36 +0200)
committerOtto Moerbeek <otto.moerbeek@open-xchange.com>
Mon, 10 Aug 2020 11:36:15 +0000 (13:36 +0200)
fallback code can be for maxdepth.

pdns/syncres.cc

index 7216434727c93e5ced0ae0e8e005faf8bd512a94..547a3b6390869191ebec5f8404b554e6ef392e34 100644 (file)
@@ -744,6 +744,9 @@ int SyncRes::doResolve(const DNSName &qname, const QType &qtype, vector<DNSRecor
         // Case 5: unexpected answer
         QLOG("Step5: other rcode, last effort final resolve");
         setQNameMinimization(false);
+        // We might have hit a depth level check, but we still want to allow some recursion levels in the fallback
+        // no-qname-minimization case. This has the effect that a qname minimization fallback case might reach 150% of
+        // maxdepth.
         res = doResolveNoQNameMinimization(qname, qtype, ret, depth/2, beenthere, state);
 
         if(res == RCode::NoError) {