]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pmdomain: imx: Fix reference count leak in imx_gpc_probe()
authorWentao Liang <vulab@iscas.ac.cn>
Thu, 11 Dec 2025 04:02:52 +0000 (04:02 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:49 +0000 (10:14 +0100)
commit 73cb5f6eafb0ac7aea8cdeb8ff12981aa741d8fb upstream.

of_get_child_by_name() returns a node pointer with refcount incremented.
Use the __free() attribute to manage the pgc_node reference, ensuring
automatic of_node_put() cleanup when pgc_node goes out of scope.

This eliminates the need for explicit error handling paths and avoids
reference count leaks.

Fixes: 721cabf6c660 ("soc: imx: move PGC handling to a new GPC driver")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pmdomain/imx/gpc.c

index 00fdb5a905e2adb6a56edd12db83e0cd6e16d3f9..b811d0ad94e2f0228114881460eee284efd1eb1e 100644 (file)
@@ -403,13 +403,12 @@ clk_err:
 static int imx_gpc_probe(struct platform_device *pdev)
 {
        const struct imx_gpc_dt_data *of_id_data = device_get_match_data(&pdev->dev);
-       struct device_node *pgc_node;
+       struct device_node *pgc_node __free(device_node)
+               = of_get_child_by_name(pdev->dev.of_node, "pgc");
        struct regmap *regmap;
        void __iomem *base;
        int ret;
 
-       pgc_node = of_get_child_by_name(pdev->dev.of_node, "pgc");
-
        /* bail out if DT too old and doesn't provide the necessary info */
        if (!of_property_read_bool(pdev->dev.of_node, "#power-domain-cells") &&
            !pgc_node)