]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bcachefs: Make journal read log message a bit quieter
authorKent Overstreet <kent.overstreet@linux.dev>
Tue, 3 Jun 2025 13:31:58 +0000 (09:31 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Wed, 4 Jun 2025 20:45:41 +0000 (16:45 -0400)
Users seem to be assuming that the 'dropped unflushed entries' message
at the end of journal read indicates some sort of problem, when it does
not - we expect there to be entries in the journal that weren't
commited, it's purely informational so that we can correlate journal
sequence numbers elsewhere when debugging.

Shorten the log message a bit to hopefully make this clearer.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/journal_io.c

index d4c9980a6a7b1b53a37a4e359e80cb899db8de03..0b15d71a8d2d526dc9f0ddafcdd1a4768bd7060a 100644 (file)
@@ -1427,12 +1427,12 @@ int bch2_journal_read(struct bch_fs *c,
                return 0;
        }
 
-       bch_info(c, "journal read done, replaying entries %llu-%llu",
-                *last_seq, *blacklist_seq - 1);
-
+       printbuf_reset(&buf);
+       prt_printf(&buf, "journal read done, replaying entries %llu-%llu",
+                  *last_seq, *blacklist_seq - 1);
        if (*start_seq != *blacklist_seq)
-               bch_info(c, "dropped unflushed entries %llu-%llu",
-                        *blacklist_seq, *start_seq - 1);
+               prt_printf(&buf, " (unflushed %llu-%llu)", *blacklist_seq, *start_seq - 1);
+       bch_info(c, "%s", buf.buf);
 
        /* Drop blacklisted entries and entries older than last_seq: */
        genradix_for_each(&c->journal_entries, radix_iter, _i) {