]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: light: stk3310: Use sizeof() for regmap_bulk_read/write count parameter
authorMiao Li <limiao@kylinos.cn>
Mon, 4 May 2026 03:04:08 +0000 (11:04 +0800)
committerJonathan Cameron <jic23@kernel.org>
Sun, 31 May 2026 09:59:34 +0000 (10:59 +0100)
Convert the hardcoded count parameter to sizeof(buf) for all
regmap_bulk_write() and regmap_bulk_read() calls in this driver
to improve code maintainability. For details, see [1].

Link: https://lore.kernel.org/all/20260428192213.7c5c80e5@jic23-huawei/
Signed-off-by: Miao Li <limiao@kylinos.cn>
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/light/stk3310.c

index fb3d9821edeeb0a1c67f1b1f0c837e3806ea5685..60407bc87ccf463dd8ce05ec36efe4b6b521102c 100644 (file)
@@ -271,7 +271,7 @@ static int stk3310_read_event(struct iio_dev *indio_dev,
                return -EINVAL;
 
        mutex_lock(&data->lock);
-       ret = regmap_bulk_read(data->regmap, reg, &buf, 2);
+       ret = regmap_bulk_read(data->regmap, reg, &buf, sizeof(buf));
        mutex_unlock(&data->lock);
        if (ret < 0) {
                dev_err(&data->client->dev, "register read failed\n");
@@ -311,7 +311,7 @@ static int stk3310_write_event(struct iio_dev *indio_dev,
                return -EINVAL;
 
        buf = cpu_to_be16(val);
-       ret = regmap_bulk_write(data->regmap, reg, &buf, 2);
+       ret = regmap_bulk_write(data->regmap, reg, &buf, sizeof(buf));
        if (ret < 0) {
                dev_err(&client->dev, "failed to set PS threshold!\n");
                return ret;
@@ -389,7 +389,7 @@ static int stk3310_read_raw(struct iio_dev *indio_dev,
                        reg = STK3310_REG_PS_DATA_MSB;
 
                mutex_lock(&data->lock);
-               ret = regmap_bulk_read(data->regmap, reg, &buf, 2);
+               ret = regmap_bulk_read(data->regmap, reg, &buf, sizeof(buf));
                if (ret < 0) {
                        dev_err(&client->dev, "register read failed\n");
                        mutex_unlock(&data->lock);
@@ -739,7 +739,7 @@ static int stk3310_resume(struct device *dev)
 
        if (data->ps_thdl != 0x0) {
                buf = cpu_to_be16(data->ps_thdl);
-               ret = regmap_bulk_write(data->regmap, STK3310_REG_THDL_PS, &buf, 2);
+               ret = regmap_bulk_write(data->regmap, STK3310_REG_THDL_PS, &buf, sizeof(buf));
                if (ret < 0) {
                        dev_err(dev, "failed to set reg THDL_PS at resume.\n");
                        return ret;
@@ -748,7 +748,7 @@ static int stk3310_resume(struct device *dev)
 
        if (data->ps_thdh != STK3310_PS_MAX_VAL) {
                buf = cpu_to_be16(data->ps_thdh);
-               ret = regmap_bulk_write(data->regmap, STK3310_REG_THDH_PS, &buf, 2);
+               ret = regmap_bulk_write(data->regmap, STK3310_REG_THDH_PS, &buf, sizeof(buf));
                if (ret < 0) {
                        dev_err(dev, "failed to set reg THDH_PS at resume.\n");
                        return ret;