core/device: check that no unit is ready and not simultaneously

This should not happen, just for safety.

diff --git a/src/core/device.c b/src/core/device.c
index 21dc5890fc5a2d18c96c4c8354b468b540e6063c..b3cf77d50c601216748e74f27e11d0d8593783b5 100644 (file)
--- a/src/core/device.c
+++ b/src/core/device.c
@@ -903,6 +903,13 @@ static int device_setup_units(Manager *m, sd_device *dev, Set **ready_units, Set
 
         /* Next, add/update additional .device units point to aliases and symlinks. */
         (void) device_setup_extra_units(m, dev, ready_units, not_ready_units);
+
+        /* Safety check: no unit should be in ready_units and not_ready_units simultaneously. */
+        Unit *u;
+        SET_FOREACH(u, *not_ready_units)
+                if (set_remove(*ready_units, u))
+                        log_unit_error(u, "Cannot active and deactive simultaneously. Deactivating.");
+
         return 0;
 }