]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: 3com: 3c59x: fix possible null dereference in vortex_probe1()
authorThomas Fourier <fourier.thomas@gmail.com>
Tue, 6 Jan 2026 09:47:21 +0000 (10:47 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 8 Jan 2026 16:36:56 +0000 (08:36 -0800)
pdev can be null and free_ring: can be called in 1297 with a null
pdev.

Fixes: 55c82617c3e8 ("3c59x: convert to generic DMA API")
Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
Link: https://patch.msgid.link/20260106094731.25819-2-fourier.thomas@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/3com/3c59x.c

index 8c9cc97efd4eefbf2a110da48301526db0f143b1..4fe4efdb3737fd18c1cc676b2819c0170c0206cb 100644 (file)
@@ -1473,7 +1473,7 @@ static int vortex_probe1(struct device *gendev, void __iomem *ioaddr, int irq,
                return 0;
 
 free_ring:
-       dma_free_coherent(&pdev->dev,
+       dma_free_coherent(gendev,
                sizeof(struct boom_rx_desc) * RX_RING_SIZE +
                sizeof(struct boom_tx_desc) * TX_RING_SIZE,
                vp->rx_ring, vp->rx_ring_dma);