* grub-core/commands/lsacpi.c (disp_acpi_xsdt_table): #if'-out the

	checks which are always false on some platforms.
	(grub_cmd_lsacpi): Likewise.
	* grub-core/kern/misc.c (grub_strtoul): Likewise.
	* grub-core/loader/multiboot.c (grub_multiboot_set_video_mode):
	Likewise.

diff --git a/ChangeLog b/ChangeLog
index f02f35fd10471bc347a6984ef6201f771a5a4bb7..20bb5963bc0e73fd20b5ead77821af7872a2f5a2 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2012-02-09  Vladimir Serbinenko  <phcoder@gmail.com>
+
+       * grub-core/commands/lsacpi.c (disp_acpi_xsdt_table): #if'-out the
+       checks which are always false on some platforms.
+       (grub_cmd_lsacpi): Likewise.
+       * grub-core/kern/misc.c (grub_strtoul): Likewise.
+       * grub-core/loader/multiboot.c (grub_multiboot_set_video_mode):
+       Likewise.
+
 2012-02-09  Vladimir Serbinenko  <phcoder@gmail.com>
 
        * grub-core/disk/diskfilter.c (read_segment): Renome unreachable code.

diff --git a/grub-core/commands/lsacpi.c b/grub-core/commands/lsacpi.c
index fe6f70341c736d37d3ff7863ed287c1e3fd15568..f219022a015c55fe5f6b2f4e3c1f46d21fcece70 100644 (file)
--- a/grub-core/commands/lsacpi.c
+++ b/grub-core/commands/lsacpi.c
@@ -132,11 +132,13 @@ disp_acpi_xsdt_table (struct grub_acpi_table_header *t)
   desc = (grub_uint64_t *) (t + 1);
   for (; len > 0; desc++, len -= sizeof (*desc))
     {
-      if (sizeof (grub_addr_t) == 4 && *desc >= (1ULL << 32))
+#if GRUB_CPU_SIZEOF_VOID_P == 4
+      if (*desc >= (1ULL << 32))
        {
          grub_printf ("Unreachable table\n");
          continue;
        }
+#endif
       t = (struct grub_acpi_table_header *) (grub_addr_t) *desc;
 
       if (t == NULL)
@@ -222,9 +224,11 @@ grub_cmd_lsacpi (struct grub_extcmd_context *ctxt,
        grub_printf ("No RSDPv2\n");
       else
        {
-         if (sizeof (grub_addr_t) == 4 && rsdp2->xsdt_addr >= (1ULL << 32))
-             grub_printf ("Unreachable RSDPv2\n");
+#if GRUB_CPU_SIZEOF_VOID_P == 4
+         if (rsdp2->xsdt_addr >= (1ULL << 32))
+           grub_printf ("Unreachable RSDPv2\n");
          else
+#endif
            {
              grub_printf ("RSDPv2 signature:");
              disp_acpi_rsdpv2 (rsdp2);

diff --git a/grub-core/kern/misc.c b/grub-core/kern/misc.c
index 0d2ae4bd6c34867bd981faf30c9a9b7cc395ad57..ebeab0ec4dcc91d328ace34e26a6c737b01cc142 100644 (file)
--- a/grub-core/kern/misc.c
+++ b/grub-core/kern/misc.c
@@ -370,11 +370,13 @@ grub_strtoul (const char *str, char **end, int base)
   unsigned long long num;
 
   num = grub_strtoull (str, end, base);
+#if GRUB_CPU_SIZEOF_LONG != 8
   if (num > ~0UL)
     {
       grub_error (GRUB_ERR_OUT_OF_RANGE, "overflow is detected");
       return ~0UL;
     }
+#endif
 
   return (unsigned long) num;
 }

diff --git a/grub-core/loader/multiboot.c b/grub-core/loader/multiboot.c
index 9c1fd9146a11adf7fa7e17a35099cc8066d8f2d4..d8951ce9e1caa7a5bfe8cebd203d4cc333a7ca6f 100644 (file)
--- a/grub-core/loader/multiboot.c
+++ b/grub-core/loader/multiboot.c
@@ -90,7 +90,9 @@ grub_multiboot_set_video_mode (void)
   grub_err_t err;
   const char *modevar;
 
-  if (accepts_video || !GRUB_MACHINE_HAS_VGA_TEXT)
+#if GRUB_MACHINE_HAS_VGA_TEXT
+  if (accepts_video)
+#endif
     {
       modevar = grub_env_get ("gfxpayload");
       if (! modevar || *modevar == 0)
@@ -105,8 +107,10 @@ grub_multiboot_set_video_mode (void)
          grub_free (tmp);
        }
     }
+#if GRUB_MACHINE_HAS_VGA_TEXT
   else
     err = grub_video_set_mode ("text", 0, 0);
+#endif
 
   return err;
 }