]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
Input: palmas-pwrbutton - replace use of system_wq with system_dfl_wq
authorMarco Crivellari <marco.crivellari@suse.com>
Thu, 6 Nov 2025 14:19:53 +0000 (15:19 +0100)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 19 Dec 2025 04:52:48 +0000 (20:52 -0800)
Currently if a user enqueues a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

This patch continues the effort to refactor worqueue APIs, which has begun
with the change introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

This specific workload do not benefit from a per-cpu workqueue, so use
the default unbound workqueue (system_dfl_wq) instead.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Link: https://patch.msgid.link/20251106141955.218911-3-marco.crivellari@suse.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/palmas-pwrbutton.c

index 39fc451c56e924691e1d007cc8ada9b64c2952e2..d9c5aae143dc83e76e0ee5ca6323ffa727c4d3ba 100644 (file)
@@ -91,7 +91,7 @@ static irqreturn_t pwron_irq(int irq, void *palmas_pwron)
        pm_wakeup_event(input_dev->dev.parent, 0);
        input_sync(input_dev);
 
-       mod_delayed_work(system_wq, &pwron->input_work,
+       mod_delayed_work(system_dfl_wq, &pwron->input_work,
                         msecs_to_jiffies(PALMAS_PWR_KEY_Q_TIME_MS));
 
        return IRQ_HANDLED;