]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: verisilicon: AV1: Fix tile info buffer size
authorBenjamin Gaignard <benjamin.gaignard@collabora.com>
Wed, 14 Jan 2026 09:07:10 +0000 (10:07 +0100)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 21 Jan 2026 13:43:09 +0000 (14:43 +0100)
Each tile info is composed of: row_sb, col_sb, start_pos
and end_pos (4 bytes each). So the total required memory
is AV1_MAX_TILES * 16 bytes.
Use the correct #define to allocate the buffer and avoid
writing tile info in non-allocated memory.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Fixes: 727a400686a2c ("media: verisilicon: Add Rockchip AV1 decoder")
Cc: stable@vger.kernel.org
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c

index 500e94bcb02937c7ff66869ba135f415ba95ef36..e4e21ad373233e1b2637330a342aac441cff9604 100644 (file)
@@ -381,12 +381,12 @@ int rockchip_vpu981_av1_dec_init(struct hantro_ctx *ctx)
                return -ENOMEM;
        av1_dec->global_model.size = GLOBAL_MODEL_SIZE;
 
-       av1_dec->tile_info.cpu = dma_alloc_coherent(vpu->dev, AV1_MAX_TILES,
+       av1_dec->tile_info.cpu = dma_alloc_coherent(vpu->dev, AV1_TILE_INFO_SIZE,
                                                    &av1_dec->tile_info.dma,
                                                    GFP_KERNEL);
        if (!av1_dec->tile_info.cpu)
                return -ENOMEM;
-       av1_dec->tile_info.size = AV1_MAX_TILES;
+       av1_dec->tile_info.size = AV1_TILE_INFO_SIZE;
 
        av1_dec->film_grain.cpu = dma_alloc_coherent(vpu->dev,
                                                     ALIGN(sizeof(struct rockchip_av1_film_grain), 2048),