]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Revert commit 06f81c63ebc19cb0e51f9b397991f6d6ae56d090
authorDaniel P. Berrange <berrange@redhat.com>
Fri, 29 Oct 2010 10:47:20 +0000 (11:47 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 2 Nov 2010 14:37:26 +0000 (14:37 +0000)
Commit 06f81c63ebc19cb0e51f9b397991f6d6ae56d090 attempted to make
QEMU driver ignore the failure to relabel 'stdin_path' if it was
on NFS. The actual result was that it ignores *all* failures to
label any aspect of the VM, unless stdin_path is non-NULL and
is not on NFS.

* src/qemu/qemu_driver.c: Treat all relabel failures as terminal

src/qemu/qemu_driver.c

index 0612e69e98fa92bc5ba5aa17c0b6da02d490bea1..4e590e33748e8aa9d95dd288cc38185dad260fba 100644 (file)
@@ -3912,8 +3912,7 @@ static int qemudStartVMDaemon(virConnectPtr conn,
         driver->securityDriver->domainSetSecurityAllLabel &&
         driver->securityDriver->domainSetSecurityAllLabel(driver->securityDriver,
                                                           vm, stdin_path) < 0) {
-        if (stdin_path && virStorageFileIsSharedFS(stdin_path) != 1)
-            goto cleanup;
+        goto cleanup;
     }
 
     /* Ensure no historical cgroup for this VM is lying around bogus