]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
xen: privcmd: Don't mark eventfd waiter as EXCLUSIVE
authorSean Christopherson <seanjc@google.com>
Thu, 22 May 2025 23:52:17 +0000 (16:52 -0700)
committerSean Christopherson <seanjc@google.com>
Mon, 23 Jun 2025 16:50:57 +0000 (09:50 -0700)
Don't set WQ_FLAG_EXCLUSIVE when adding an irqfd to a wait queue, as
irqfd_wakeup() unconditionally returns '0', i.e. doesn't actually operate
in exclusive mode.

Note, the use of WQ_FLAG_PRIORITY is also dubious, but that's a problem
for another day.

Tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250522235223.3178519-8-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
drivers/xen/privcmd.c

index c08ec8a7d27c1d37bcf84cb7131993c16785e7bb..13a10f3294a80d8daa231ac556a998b2e494378a 100644 (file)
@@ -957,7 +957,6 @@ irqfd_poll_func(struct file *file, wait_queue_head_t *wqh, poll_table *pt)
        struct privcmd_kernel_irqfd *kirqfd =
                container_of(pt, struct privcmd_kernel_irqfd, pt);
 
-       kirqfd->wait.flags |= WQ_FLAG_EXCLUSIVE;
        add_wait_queue_priority(wqh, &kirqfd->wait);
 }