]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tipc: re-configure queue limit for broadcast link
authorHoang Huu Le <hoang.h.le@dektech.com.au>
Fri, 16 Oct 2020 02:31:18 +0000 (09:31 +0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:07:04 +0000 (10:07 +0100)
[ Upstream commit 75cee397ae6f1020fbb75db90aa22a51bc3318ac ]

The queue limit of the broadcast link is being calculated base on initial
MTU. However, when MTU value changed (e.g manual changing MTU on NIC
device, MTU negotiation etc.,) we do not re-calculate queue limit.
This gives throughput does not reflect with the change.

So fix it by calling the function to re-calculate queue limit of the
broadcast link.

Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Huu Le <hoang.h.le@dektech.com.au>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/tipc/bcast.c

index 383f87bc10615ed74111a53a8cb8d6bf08c0ec92..49a8b7d6f6bb78d098fd41ae4049cf2e136f1488 100644 (file)
@@ -108,6 +108,7 @@ static void tipc_bcbase_select_primary(struct net *net)
 {
        struct tipc_bc_base *bb = tipc_bc_base(net);
        int all_dests =  tipc_link_bc_peers(bb->link);
+       int max_win = tipc_link_max_win(bb->link);
        int i, mtu, prim;
 
        bb->primary_bearer = INVALID_BEARER_ID;
@@ -121,8 +122,11 @@ static void tipc_bcbase_select_primary(struct net *net)
                        continue;
 
                mtu = tipc_bearer_mtu(net, i);
-               if (mtu < tipc_link_mtu(bb->link))
+               if (mtu < tipc_link_mtu(bb->link)) {
                        tipc_link_set_mtu(bb->link, mtu);
+                       tipc_link_set_queue_limits(bb->link, max_win,
+                                                  max_win);
+               }
                bb->bcast_support &= tipc_bearer_bcast_support(net, i);
                if (bb->dests[i] < all_dests)
                        continue;