]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
lib/cmdline_kunit: add test case for memparse()
authorDmitry Antipov <dmantipov@yandex.ru>
Tue, 19 May 2026 17:22:55 +0000 (20:22 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 29 May 2026 04:24:50 +0000 (21:24 -0700)
Better late than never, now there is a long-awaited basic test for
'memparse()' which is provided by cmdline.c.

Link: https://lore.kernel.org/20260519172259.908980-5-dmantipov@yandex.ru
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: Alexandre Ghiti <alex@ghiti.fr>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Charlie Jenkins <thecharlesjenkins@gmail.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/tests/cmdline_kunit.c

index af44ae9e92c3e7bcb9535ce38e2896380a2d53de..3f61ff8d317821b584ea2984b85a0d08afdf7cca 100644 (file)
@@ -6,6 +6,7 @@
 #include <kunit/test.h>
 #include <linux/kernel.h>
 #include <linux/random.h>
+#include <linux/sizes.h>
 #include <linux/string.h>
 
 static const char *cmdline_test_strings[] = {
@@ -198,6 +199,60 @@ static void cmdline_test_next_arg_mixed_tokens(struct kunit *test)
        KUNIT_EXPECT_STREQ(test, next, "");
 }
 
+struct cmdline_test_memparse_entry {
+       const char *input;
+       const char *unrecognized;
+       unsigned long long result;
+};
+
+static const struct cmdline_test_memparse_entry testdata[] = {
+       { "0",                          "",     0ULL },
+       { "1",                          "",     1ULL },
+       { "a",                          "a",    0ULL },
+       { "k",                          "k",    0ULL },
+       { "E",                          "E",    0ULL },
+       { "0xb",                        "",     11ULL },
+       { "0xz",                        "x",    0ULL },
+       { "1234",                       "",     1234ULL },
+       { "04567",                      "",     2423ULL },
+       { "0x9876",                     "",     39030LL },
+       { "05678",                      "8",    375ULL },
+       { "0xabcdefz",                  "z",    11259375ULL },
+       { "0cdba",                      "c",    0ULL },
+       { "4K",                         "",     SZ_4K },
+       { "0x10k@0xaaaabbbb",           "@",    SZ_16K },
+       { "32M",                        "",     SZ_32M },
+       { "067m:foo",                   ":",    55 * SZ_1M },
+       { "2G;bar=baz",                 ";",    SZ_2G },
+       { "07gz",                       "z",    7ULL * SZ_1G },
+       { "3T+data",                    "+",    3 * SZ_1T },
+       { "04t,ro",                     ",",    SZ_4T },
+       { "012p",                       "",     11258999068426240ULL },
+       { "7P,sync",                    ",",    7881299347898368ULL },
+       { "0x2e",                       "",     46ULL },
+       { "2E and more",                " ",    2305843009213693952ULL },
+       { "18446744073709551615",       "",     ULLONG_MAX },
+       { "0xffffffffffffffff0",        "",     ULLONG_MAX },
+       { "1111111111111111111T",       "",     ULLONG_MAX },
+       { "222222222222222222222G",     "",     ULLONG_MAX },
+       { "3333333333333333333333M",    "",     ULLONG_MAX },
+};
+
+static void cmdline_test_memparse(struct kunit *test)
+{
+       const struct cmdline_test_memparse_entry *e;
+       unsigned long long ret;
+       char *retptr;
+
+       for (e = testdata; e < testdata + ARRAY_SIZE(testdata); e++) {
+               ret = memparse(e->input, &retptr);
+               KUNIT_EXPECT_EQ_MSG(test, ret, e->result,
+                                   "    when parsing '%s'", e->input);
+               KUNIT_EXPECT_EQ_MSG(test, *retptr, *e->unrecognized,
+                                   "    when parsing '%s'", e->input);
+       }
+}
+
 static struct kunit_case cmdline_test_cases[] = {
        KUNIT_CASE(cmdline_test_noint),
        KUNIT_CASE(cmdline_test_lead_int),
@@ -206,6 +261,7 @@ static struct kunit_case cmdline_test_cases[] = {
        KUNIT_CASE(cmdline_test_next_arg_quoted_value),
        KUNIT_CASE(cmdline_test_next_arg_bare_quote_regression),
        KUNIT_CASE(cmdline_test_next_arg_mixed_tokens),
+       KUNIT_CASE(cmdline_test_memparse),
        {}
 };