usb: typec: mux: avoid duplicated orientation switches

Some devices use combo PHYs (i.e. USB3 + DisplayPort), which also
handle the orientation mux. These PHYs are referenced twice from
the USB-C connector (USB super-speed lines and SBU/AUX lines)
resulting in the switch being configured twice. Avoid this by
dropping duplicates.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://patch.msgid.link/20260223-typec-mux-duplication-fix-v2-1-0402fefc222e@collabora.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c
index 58fb97ea6877a76e07996781b4ac68142a28e986..9b908c46bd7df9fe78ac0a5eeeb9b03d6587ba80 100644 (file)
--- a/drivers/usb/typec/mux.c
+++ b/drivers/usb/typec/mux.c
@@ -35,7 +35,9 @@ static int switch_fwnode_match(struct device *dev, const void *fwnode)
 static void *typec_switch_match(const struct fwnode_handle *fwnode,
                                const char *id, void *data)
 {
+       struct typec_switch_dev **sw_devs = data;
        struct device *dev;
+       int i;
 
        /*
         * Device graph (OF graph) does not give any means to identify the
@@ -56,6 +58,13 @@ static void *typec_switch_match(const struct fwnode_handle *fwnode,
        dev = class_find_device(&typec_mux_class, NULL, fwnode,
                                switch_fwnode_match);
 
+       /* Skip duplicates */
+       for (i = 0; i < TYPEC_MUX_MAX_DEVS; i++)
+               if (to_typec_switch_dev(dev) == sw_devs[i]) {
+                       put_device(dev);
+                       return NULL;
+               }
+
        return dev ? to_typec_switch_dev(dev) : ERR_PTR(-EPROBE_DEFER);
 }
 
@@ -80,7 +89,8 @@ struct typec_switch *fwnode_typec_switch_get(struct fwnode_handle *fwnode)
        if (!sw)
                return ERR_PTR(-ENOMEM);
 
-       count = fwnode_connection_find_matches(fwnode, "orientation-switch", NULL,
+       count = fwnode_connection_find_matches(fwnode, "orientation-switch",
+                                              (void **)sw_devs,
                                               typec_switch_match,
                                               (void **)sw_devs,
                                               ARRAY_SIZE(sw_devs));