]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: libsmb: In cli_setatr_send() (SMBsetatr) check for DFS pathname.
authorJeremy Allison <jra@samba.org>
Thu, 8 Sep 2022 18:53:33 +0000 (11:53 -0700)
committerJeremy Allison <jra@samba.org>
Thu, 15 Sep 2022 18:43:32 +0000 (18:43 +0000)
smbtorture3: SMB1-DFS-OPERATIONS: test_smb1_setatr() shows
SMBsetatr uses DFS paths.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
source3/libsmb/clifile.c

index 246759305fbeef0ebd3f87df5b748c395f4ecb51..34c3dcaa861a60671382327bf0efd1bfaf013232 100644 (file)
@@ -4664,6 +4664,7 @@ struct tevent_req *cli_setatr_send(TALLOC_CTX *mem_ctx,
        uint8_t additional_flags = 0;
        uint16_t additional_flags2 = 0;
        uint8_t *bytes = NULL;
+       char *fname_cp = NULL;
 
        req = tevent_req_create(mem_ctx, &state, struct cli_setatr_state);
        if (req == NULL) {
@@ -4687,9 +4688,19 @@ struct tevent_req *cli_setatr_send(TALLOC_CTX *mem_ctx,
        if (tevent_req_nomem(bytes, req)) {
                return tevent_req_post(req, ev);
        }
+       /*
+        * SMBsetatr on a DFS share must use DFS names.
+        */
+       fname_cp = smb1_dfs_share_path(state, cli, fname);
+       if (tevent_req_nomem(fname_cp, req)) {
+               return tevent_req_post(req, ev);
+       }
        bytes[0] = 4;
-       bytes = smb_bytes_push_str(bytes, smbXcli_conn_use_unicode(cli->conn), fname,
-                                  strlen(fname)+1, NULL);
+       bytes = smb_bytes_push_str(bytes,
+                                  smbXcli_conn_use_unicode(cli->conn),
+                                  fname_cp,
+                                  strlen(fname_cp)+1,
+                                  NULL);
        if (tevent_req_nomem(bytes, req)) {
                return tevent_req_post(req, ev);
        }