]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: magnetometer: Remove IRQF_ONESHOT
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 28 Jan 2026 09:55:38 +0000 (10:55 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 29 Jan 2026 16:13:11 +0000 (16:13 +0000)
Passing IRQF_ONESHOT ensures that the interrupt source is masked until
the secondary (threaded) handler is done. If only a primary handler is
used then the flag makes no sense because the interrupt can not fire
(again) while its handler is running.
The flag also disallows force-threading of the primary handler and the
irq-core will warn about this.
The force-threading functionality is required on PREEMPT_RT because the
handler is using locks with can sleep on PREEMPT_RT.

Remove IRQF_ONESHOT from irqflags.

Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/magnetometer/ak8975.c

index 3fd0171e5d69b6fe98e63df599f4fe311af6be52..d30315ad85ded31d41c7e878fabcc25080794b45 100644 (file)
@@ -581,7 +581,7 @@ static int ak8975_setup_irq(struct ak8975_data *data)
                irq = gpiod_to_irq(data->eoc_gpiod);
 
        rc = devm_request_irq(&client->dev, irq, ak8975_irq_handler,
-                             IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+                             IRQF_TRIGGER_RISING,
                              dev_name(&client->dev), data);
        if (rc < 0) {
                dev_err(&client->dev, "irq %d request failed: %d\n", irq, rc);