]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Remove return value from qemuMonitorDomainDumpCompletedCallback
authorPeter Krempa <pkrempa@redhat.com>
Tue, 20 Jul 2021 08:05:06 +0000 (10:05 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 23 Jul 2021 08:01:48 +0000 (10:01 +0200)
Change the callback prototype and fix the callback registered in the
process code.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_monitor.h
src/qemu/qemu_process.c

index 6806ff95525b2a7ef7f95dd7d0dabef6fa40b009..1de39e81ebb5c4c32df4238899b683be3d818e51 100644 (file)
@@ -303,12 +303,12 @@ struct _qemuMonitorDumpStats {
     unsigned long long total; /* total bytes to be written */
 };
 
-typedef int (*qemuMonitorDomainDumpCompletedCallback)(qemuMonitor *mon,
-                                                      virDomainObj *vm,
-                                                      int status,
-                                                      qemuMonitorDumpStats *stats,
-                                                      const char *error,
-                                                      void *opaque);
+typedef void (*qemuMonitorDomainDumpCompletedCallback)(qemuMonitor *mon,
+                                                       virDomainObj *vm,
+                                                       int status,
+                                                       qemuMonitorDumpStats *stats,
+                                                       const char *error,
+                                                       void *opaque);
 
 typedef int (*qemuMonitorDomainPRManagerStatusChangedCallback)(qemuMonitor *mon,
                                                                virDomainObj *vm,
index 9c7aa547b564a64223d6a1b0714fb5b75a8a15de..7e4a025e3501c8a1830bb2ba4380aa4eb226c30f 100644 (file)
@@ -1663,7 +1663,7 @@ qemuProcessHandleMigrationPass(qemuMonitor *mon G_GNUC_UNUSED,
 }
 
 
-static int
+static void
 qemuProcessHandleDumpCompleted(qemuMonitor *mon G_GNUC_UNUSED,
                                virDomainObj *vm,
                                int status,
@@ -1700,7 +1700,6 @@ qemuProcessHandleDumpCompleted(qemuMonitor *mon G_GNUC_UNUSED,
  cleanup:
     virResetLastError();
     virObjectUnlock(vm);
-    return 0;
 }