parser-helper: Don't attempt to open anything but regular files

A crash could be provoked e.g. via STRONGSWAN_CONF=. or any other
path to a directory.

diff --git a/src/libstrongswan/utils/parser_helper.c b/src/libstrongswan/utils/parser_helper.c
index 3ed22b61de1c203e0314ced7f801fdae8583924e..bcda3b106d1f02997f11bd989583cc377228a8e8 100644 (file)
--- a/src/libstrongswan/utils/parser_helper.c
+++ b/src/libstrongswan/utils/parser_helper.c
@@ -16,6 +16,8 @@
 #include <limits.h>
 #include <ctype.h>
 #include <stdarg.h>
+#include <sys/types.h>
+#include <sys/stat.h>
 
 #include "parser_helper.h"
 
@@ -93,6 +95,7 @@ METHOD(parser_helper_t, file_next, FILE*,
        private_parser_helper_t *this)
 {
        parser_helper_file_t *file, *next;
+       struct stat st;
        char *name;
 
        array_get(this->files, ARRAY_TAIL, &file);
@@ -112,7 +115,8 @@ METHOD(parser_helper_t, file_next, FILE*,
                                .file = fopen(name, "r"),
                        );
 
-                       if (next->file)
+                       if (next->file && fstat(fileno(next->file), &st) == 0 &&
+                               S_ISREG(st.st_mode))
                        {
                                array_insert(this->files, ARRAY_TAIL, next);
                                return next->file;