]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
firmware: scmi: Drop mmu_set_region_dcache_behaviour() misuse
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Sat, 25 Oct 2025 21:35:09 +0000 (23:35 +0200)
committerPeng Fan <peng.fan@nxp.com>
Mon, 10 Nov 2025 12:57:42 +0000 (20:57 +0800)
MMU region cache behavior configuration for SCMI/SMT mailboxes is
platform specific. Even on ARM systems, the mailbox memory may not
even be located in any cacheable MMU region and may instead reside
in some SRAM. Remove this non-generic cache behavior configuration
code from generic code path.

It is unlikely that any platform is affected by this change if it
did configure its MMU regions correctly on start up. Platforms
which might be affected are i.MX94/95 and STM32MP.

Fixes: 240720e9052f ("firmware: scmi: mailbox/smt agent device")
Fixes: 2a3f161c8b16 ("scmi: correctly configure MMU for SCMI buffer")
Fixes: b2ae10970d40 ("firmware: scmi: use PAGE_SIZE alignment for ARM64")
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Tested-by: Alice Guo <alice.guo@nxp.com>
Tested-by: Patrice Chotard <patrice.chotard@foss.st.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
drivers/firmware/scmi/smt.c

index 237871559f01b4ecf8079f943b666000d5059535..cd1c0801f721938fbd27c0066977fce3ac911b07 100644 (file)
@@ -61,20 +61,6 @@ int scmi_dt_get_smt_buffer(struct udevice *dev, struct scmi_smt *smt)
        if (device_is_compatible(dev, "arm,scmi") && ofnode_has_property(dev_ofnode(dev), "mboxes"))
                scmi_smt_enable_intr(smt, true);
 
-#ifdef CONFIG_ARM
-       if (dcache_status()) {
-               u32 align_size;
-
-               if (IS_ENABLED(CONFIG_ARM64))
-                       align_size = PAGE_SIZE;
-               else
-                       align_size = MMU_SECTION_SIZE;
-
-               mmu_set_region_dcache_behaviour(ALIGN_DOWN((uintptr_t)smt->buf, align_size),
-                                               ALIGN(smt->size, align_size), DCACHE_OFF);
-       }
-#endif
-
        return 0;
 }