]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mm: simplify folio_migrate_mapping()
authorHugh Dickins <hughd@google.com>
Sat, 6 Jul 2024 21:29:00 +0000 (14:29 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 12 Jul 2024 22:52:21 +0000 (15:52 -0700)
Now that folio_undo_large_rmappable() is an inline function checking
order and large_rmappable for itself (and __folio_undo_large_rmappable()
is now declared even when CONFIG_TRANASPARENT_HUGEPAGE is off) there is
no need for folio_migrate_mapping() to check large and large_rmappable
first (in the mapping case when it has had to freeze anyway).

Link: https://lkml.kernel.org/r/68feee73-050e-8e98-7a3a-abf78738d92c@google.com
Signed-off-by: Hugh Dickins <hughd@google.com>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Barry Song <baohua@kernel.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Nhat Pham <nphamcs@gmail.com>
Cc: Yang Shi <shy828301@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/migrate.c

index ff512c43fecb85b0ff84fb6be3f8263565ae0fb8..6eb9df239230c2e6932aa0eb2e1278d923fa4be9 100644 (file)
@@ -438,8 +438,7 @@ static int __folio_migrate_mapping(struct address_space *mapping,
        }
 
        /* Take off deferred split queue while frozen and memcg set */
-       if (folio_test_large(folio) && folio_test_large_rmappable(folio))
-               folio_undo_large_rmappable(folio);
+       folio_undo_large_rmappable(folio);
 
        /*
         * Now we know that no one else is looking at the folio: