]> git.ipfire.org Git - thirdparty/shadow.git/commitdiff
semanage: Do not set default SELinux range
authorMartin Kletzander <mkletzan@redhat.com>
Fri, 3 Mar 2023 14:09:19 +0000 (15:09 +0100)
committerIker Pedrosa <ikerpedrosam@gmail.com>
Fri, 31 Mar 2023 14:13:02 +0000 (16:13 +0200)
Both semanage and libsemanage actually set the user's mls range to the
default of the seuser, which makes more sense and removes a bit of code
for usermod and useradd.  More fine-grained details must always be set
with some other tool
(semanage) anyway.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
lib/semanage.c

index 3f21b3eeb88f446c1a4ad488266ff04d00bce29b..bbb3f9937d9bbc40ae95abf85cc4d42a6079522f 100644 (file)
 
 #include "shadowlog_internal.h"
 
-#ifndef DEFAULT_SERANGE
-#define DEFAULT_SERANGE "s0"
-#endif
-
 
 format_attr(printf, 3, 4)
 static void semanage_error_callback (unused void *varg,
@@ -122,16 +118,6 @@ static int semanage_user_mod (semanage_handle_t *handle,
                goto done;
        }
 
-       if (semanage_mls_enabled(handle)) {
-               ret = semanage_seuser_set_mlsrange (handle, seuser, DEFAULT_SERANGE);
-               if (ret != 0) {
-                       fprintf (shadow_logfd,
-                                _("Could not set serange for %s\n"), login_name);
-                       ret = 1;
-                       goto done;
-               }
-       }
-
        ret = semanage_seuser_set_sename (handle, seuser, seuser_name);
        if (ret != 0) {
                fprintf (shadow_logfd,
@@ -181,16 +167,6 @@ static int semanage_user_add (semanage_handle_t *handle,
                goto done;
        }
 
-       if (semanage_mls_enabled(handle)) {
-               ret = semanage_seuser_set_mlsrange (handle, seuser, DEFAULT_SERANGE);
-               if (ret != 0) {
-                       fprintf (shadow_logfd,
-                                _("Could not set serange for %s\n"), login_name);
-                       ret = 1;
-                       goto done;
-               }
-       }
-
        ret = semanage_seuser_set_sename (handle, seuser, seuser_name);
        if (ret != 0) {
                fprintf (shadow_logfd,