]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
serial: 8250: 8250_omap.c: Clear DMA RX running status only after DMA termination...
authorMoteen Shah <m-shah@ti.com>
Mon, 12 Jan 2026 08:18:29 +0000 (13:48 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Jan 2026 13:25:45 +0000 (14:25 +0100)
Clear rx_running flag only after DMA teardown polling completes. In the
previous implementation the flag was being cleared while hardware teardown
was still in progress, creating a mismatch between software state
(flag = 0, "ready") and hardware state (still terminating).

Signed-off-by: Moteen Shah <m-shah@ti.com>
Link: https://patch.msgid.link/20260112081829.63049-3-m-shah@ti.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_omap.c

index e26bae0a6488f1878aae5d7502338668313c2592..272bc07c9a6b52354307d6d0997305413626e210 100644 (file)
@@ -931,7 +931,6 @@ static void __dma_rx_do_complete(struct uart_8250_port *p)
                goto out;
 
        cookie = dma->rx_cookie;
-       dma->rx_running = 0;
 
        /* Re-enable RX FIFO interrupt now that transfer is complete */
        if (priv->habit & UART_HAS_RHR_IT_DIS) {
@@ -965,6 +964,7 @@ static void __dma_rx_do_complete(struct uart_8250_port *p)
                goto out;
        ret = tty_insert_flip_string(tty_port, dma->rx_buf, count);
 
+       dma->rx_running = 0;
        p->port.icount.rx += ret;
        p->port.icount.buf_overrun += count - ret;
 out: