-Fix review comment for use-after-free when failing to send UDP out.

diff --git a/doc/Changelog b/doc/Changelog
index 9b9dd0557cda6a3ef1241adc23a80229f84a085b..5349877897a60c50ec2d24946fabb9724f540d5a 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,3 +1,6 @@
+31 January 2022: George
+       - Fix review comment for use-after-free when failing to send UDP out.
+
 29 January 2022: George
        - Fix tls-* and ssl-* documented alternate syntax to also be available
          through remote-control and unbound-checkconf.

diff --git a/services/outside_network.c b/services/outside_network.c
index 651f221fd88f386ea9d2b7e4ca3f98abbd2e7f7e..eff7758c4a67a93b267a0d50cdef3d30e7d05c96 100644 (file)
--- a/services/outside_network.c
+++ b/services/outside_network.c
@@ -1384,8 +1384,9 @@ outnet_send_wait_udp(struct outside_network* outnet)
                                        NETEVENT_CLOSED, NULL);
                        }
                        pending_delete(outnet, pend);
+               } else {
+                       pend->sq->busy = 0;
                }
-               pend->sq->busy = 0;
        }
 }