]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
libstdc++: Fix invalid order in PSTL inplace_merge test [PR90276]
authorJonathan Wakely <jwakely@redhat.com>
Thu, 1 Feb 2024 10:06:15 +0000 (10:06 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Fri, 2 Feb 2024 10:27:16 +0000 (10:27 +0000)
This looks like a typo in the upstream test that causes a failure in
debug mode. It has been reported upstream.

libstdc++-v3/ChangeLog:

PR libstdc++/90276
* testsuite/25_algorithms/pstl/alg_merge/inplace_merge.cc: Fix
comparison function to use less-than instead of equality.

libstdc++-v3/testsuite/25_algorithms/pstl/alg_merge/inplace_merge.cc

index 576f22423b88ddcc921ef24f78bf00566935d79f..a9205553574af5ce7e0681c26a7e936605545314 100644 (file)
@@ -160,7 +160,7 @@ main()
     test_by_type<MemoryChecker>(
         [](std::size_t idx){ return MemoryChecker{std::int32_t(idx * 2)}; },
         [](std::size_t idx){ return MemoryChecker{std::int32_t(idx * 2 + 1)}; },
-        [](const MemoryChecker& val1, const MemoryChecker& val2){ return val1.value() == val2.value(); });
+        [](const MemoryChecker& val1, const MemoryChecker& val2){ return val1.value() < val2.value(); });
     EXPECT_FALSE(MemoryChecker::alive_objects() < 0, "wrong effect from inplace_merge: number of ctors calls < num of dtors calls");
     EXPECT_FALSE(MemoryChecker::alive_objects() > 0, "wrong effect from inplace_merge: number of ctors calls > num of dtors calls");