]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:librpc: Check return code of netlogon_creds_client_authenticator()
authorAndreas Schneider <asn@samba.org>
Wed, 13 Nov 2019 09:06:20 +0000 (10:06 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Thu, 14 Nov 2019 08:01:44 +0000 (08:01 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/librpc/rpc/dcerpc_schannel.c

index 36edf4b95d71fd200a556209c878fb15d3221280..d12647222eb559b35eaf1ceeeb19df57985b4680 100644 (file)
@@ -456,10 +456,16 @@ static void continue_bind_auth(struct composite_context *ctx)
        /* if we have a AES encrypted connection, verify the capabilities */
        if (ndr_syntax_id_equal(&s->table->syntax_id,
                                &ndr_table_netlogon.syntax_id)) {
+               NTSTATUS status;
                ZERO_STRUCT(s->return_auth);
 
                s->save_creds_state = *s->creds_state;
-               netlogon_creds_client_authenticator(&s->save_creds_state, &s->auth);
+               status = netlogon_creds_client_authenticator(&s->save_creds_state,
+                                                            &s->auth);
+               if (!NT_STATUS_IS_OK(status)) {
+                       composite_error(c, status);
+                       return;
+               }
 
                s->c.in.server_name = talloc_asprintf(c,
                                                      "\\\\%s",