]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
hwmon: (pmbus/core) notify on the hwmon device, not the i2c client
authorVincent Jardin <vjardin@free.fr>
Thu, 23 Jul 2026 15:44:56 +0000 (17:44 +0200)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 27 Jul 2026 18:34:24 +0000 (11:34 -0700)
pmbus_notify() calls sysfs_notify() and kobject_uevent() on the i2c
client's kobject, but the alarm attributes live on the hwmon class
device registered by pmbus_do_probe(). Notifying the parent i2c device
is a no-op for both poll(POLLPRI) waiters and udev listeners: the named
attribute does not exist on that kobject.

Notify the hwmon device instead, so poll() wakes up and "change"
uevents fire on the inX_alarm/tempX_alarm attributes when SMBALERT#
reports a fault.

Fixes: f469bde9afd1 ("hwmon: (pmbus/core) Notify hwmon events")
Cc: stable@vger.kernel.org # v6.4+
Signed-off-by: Vincent Jardin <vjardin@free.fr>
Link: https://lore.kernel.org/r/20260723-fix_hwmon_notify_v1-v1-1-5a24c528686d@free.fr
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/pmbus/pmbus_core.c

index 3143b9e0316c46b22468e69a544d4c16ba6ffa35..0081f16c3a95afc4e027ea1338674fa7c4eeac67 100644 (file)
@@ -2985,8 +2985,9 @@ static void pmbus_notify(struct pmbus_data *data, int page, int reg, int flags)
 
                if (reg == sreg && page == spage && (smask & flags)) {
                        dev_dbg(data->dev, "sysfs notify: %s", da->attr.name);
-                       sysfs_notify(&data->dev->kobj, NULL, da->attr.name);
-                       kobject_uevent(&data->dev->kobj, KOBJ_CHANGE);
+                       sysfs_notify(&data->hwmon_dev->kobj, NULL,
+                                    da->attr.name);
+                       kobject_uevent(&data->hwmon_dev->kobj, KOBJ_CHANGE);
                        flags &= ~smask;
                }