]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Mark one use of networkstatus_check_document_signature as (void)
authorNick Mathewson <nickm@torproject.org>
Thu, 21 Aug 2014 15:05:59 +0000 (11:05 -0400)
committerNick Mathewson <nickm@torproject.org>
Thu, 21 Aug 2014 15:22:42 +0000 (11:22 -0400)
Also explain why we aren't checking its return value.

[CID 1198197]

src/or/dirvote.c

index 6536b7fe9904dac3c64e5cbaec12972a47a23389..cf6b88eb31ecca60405b13ca1dfa5ecafc47f2e6 100644 (file)
@@ -2273,8 +2273,11 @@ networkstatus_add_detached_signatures(networkstatus_t *target,
     if (!sig->good_signature && !sig->bad_signature) {
       cert = authority_cert_get_by_digests(sig->identity_digest,
                                            sig->signing_key_digest);
-      if (cert)
-        networkstatus_check_document_signature(target, sig, cert);
+      if (cert) {
+        /* Not checking the return value here, since we are going to look
+         * at the status of sig->good_signature in a moment. */
+        (void) networkstatus_check_document_signature(target, sig, cert);
+      }
     }
 
     /* If this signature is good, or we don't have any signature yet,