]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: qualcomm: fix QCA7000 checksum handling
authorStefan Wahren <stefan.wahren@i2se.com>
Sat, 28 Aug 2021 14:23:15 +0000 (16:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Sep 2021 07:50:46 +0000 (09:50 +0200)
[ Upstream commit 429205da6c834447a57279af128bdd56ccd5225e ]

Based on tests the QCA7000 doesn't support checksum offloading. So assume
ip_summed is CHECKSUM_NONE and let the kernel take care of the checksum
handling. This fixes data transfer issues in noisy environments.

Reported-by: Michael Heimpold <michael.heimpold@in-tech.com>
Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qualcomm/qca_spi.c
drivers/net/ethernet/qualcomm/qca_uart.c

index 5a3b65a6eb4f247608b603815f56ab5307eaf9da..36bcb5db3be976980a83fc65d3ceaa72591634ac 100644 (file)
@@ -434,7 +434,7 @@ qcaspi_receive(struct qcaspi *qca)
                                skb_put(qca->rx_skb, retcode);
                                qca->rx_skb->protocol = eth_type_trans(
                                        qca->rx_skb, qca->rx_skb->dev);
-                               qca->rx_skb->ip_summed = CHECKSUM_UNNECESSARY;
+                               skb_checksum_none_assert(qca->rx_skb);
                                netif_rx_ni(qca->rx_skb);
                                qca->rx_skb = netdev_alloc_skb_ip_align(net_dev,
                                        net_dev->mtu + VLAN_ETH_HLEN);
index 362b4f5c162c08573f7103e71acb751774b50792..0b7301db20ed4ae31b4f5fdd418e413a7cb3c001 100644 (file)
@@ -107,7 +107,7 @@ qca_tty_receive(struct serdev_device *serdev, const unsigned char *data,
                        skb_put(qca->rx_skb, retcode);
                        qca->rx_skb->protocol = eth_type_trans(
                                                qca->rx_skb, qca->rx_skb->dev);
-                       qca->rx_skb->ip_summed = CHECKSUM_UNNECESSARY;
+                       skb_checksum_none_assert(qca->rx_skb);
                        netif_rx_ni(qca->rx_skb);
                        qca->rx_skb = netdev_alloc_skb_ip_align(netdev,
                                                                netdev->mtu +