]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
can: ctucanfd: unmap BAR0 using base address
authorAvi Weiss <thnkslprpt@gmail.com>
Thu, 23 Jul 2026 09:59:34 +0000 (12:59 +0300)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 29 Jul 2026 09:26:44 +0000 (11:26 +0200)
BAR0 is mapped into bar0_base, while cra_addr points to an offset
within that mapping and is used for other purposes.

Pass bar0_base to pci_iounmap(), instead of cra_addr, on the probe error
path so the address returned by pci_iomap() is used for unmapping.

Fixes: 792a5b678e81 ("can: ctucanfd: CTU CAN FD open-source IP core - PCI bus support.")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
Acked-by: Pavel Pisa <pisa@fel.cvut.cz>
Link: https://patch.msgid.link/20260723095934.181042-1-thnkslprpt@gmail.com
Cc: stable@kernel.org
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/ctucanfd/ctucanfd_pci.c

index 625788fa8976629e080128adecedc2d253b92c9f..f845951c5d5139fd783281cb789709990d7ce8fe 100644 (file)
@@ -194,7 +194,7 @@ err_free_board:
        pci_set_drvdata(pdev, NULL);
        kfree(bdata);
 err_pci_iounmap_bar0:
-       pci_iounmap(pdev, cra_addr);
+       pci_iounmap(pdev, bar0_base);
 err_pci_iounmap_bar1:
        pci_iounmap(pdev, addr);
 err_release_regions: