]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: iris: Remove deprecated property setting to firmware
authorDikshita Agarwal <quic_dikshita@quicinc.com>
Fri, 9 May 2025 08:38:54 +0000 (14:08 +0530)
committerHans Verkuil <hverkuil@xs4all.nl>
Thu, 3 Jul 2025 09:02:44 +0000 (11:02 +0200)
HFI_PROPERTY_CONFIG_VDEC_POST_LOOP_DEBLOCKER is deprecated and no longer
supported on current firmware, remove setting the same to firmware.

Cc: stable@vger.kernel.org
Fixes: 79865252acb6 ("media: iris: enable video driver probe of SM8250 SoC")
Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-HDK
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
Tested-by: Vikash Garodia <quic_vgarodia@quicinc.com> # on sa8775p-ride
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/qcom/iris/iris_ctrls.c
drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c
drivers/media/platform/qcom/iris/iris_hfi_gen1_defines.h
drivers/media/platform/qcom/iris/iris_platform_common.h
drivers/media/platform/qcom/iris/iris_platform_sm8250.c

index 6a514af8108e92e95993916b155425fa47422e93..915de101fcba47bf1d1d9019cc5e704b87e2b9bb 100644 (file)
@@ -17,8 +17,6 @@ static inline bool iris_valid_cap_id(enum platform_inst_fw_cap_type cap_id)
 static enum platform_inst_fw_cap_type iris_get_cap_id(u32 id)
 {
        switch (id) {
-       case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER:
-               return DEBLOCK;
        case V4L2_CID_MPEG_VIDEO_H264_PROFILE:
                return PROFILE;
        case V4L2_CID_MPEG_VIDEO_H264_LEVEL:
@@ -34,8 +32,6 @@ static u32 iris_get_v4l2_id(enum platform_inst_fw_cap_type cap_id)
                return 0;
 
        switch (cap_id) {
-       case DEBLOCK:
-               return V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER;
        case PROFILE:
                return V4L2_CID_MPEG_VIDEO_H264_PROFILE;
        case LEVEL:
index 2a86c27443eaf2e65eef8ec1bb89545fbd5ffa50..ce855a20ce4bf4973686dd3a90bcb605065673f3 100644 (file)
@@ -490,14 +490,6 @@ iris_hfi_gen1_packet_session_set_property(struct hfi_session_set_property_pkt *p
                packet->shdr.hdr.size += sizeof(u32) + sizeof(*wm);
                break;
        }
-       case HFI_PROPERTY_CONFIG_VDEC_POST_LOOP_DEBLOCKER: {
-               struct hfi_enable *en = prop_data;
-               u32 *in = pdata;
-
-               en->enable = *in;
-               packet->shdr.hdr.size += sizeof(u32) + sizeof(*en);
-               break;
-       }
        default:
                return -EINVAL;
        }
index 9f246816a286200dff465401bee8c51097dda674..e178604855c13f71e085e7e41ed3b53e7c90c57d 100644 (file)
@@ -65,7 +65,6 @@
 
 #define HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS                0x202001
 
-#define HFI_PROPERTY_CONFIG_VDEC_POST_LOOP_DEBLOCKER   0x1200001
 #define HFI_PROPERTY_PARAM_VDEC_DPB_COUNTS             0x120300e
 #define HFI_PROPERTY_CONFIG_VDEC_ENTROPY               0x1204004
 
index ac76d9e1ef9c14dd132f306fae55cccbfa141092..1dab276431c716f39d89f3c92f930194ae2275d1 100644 (file)
@@ -89,7 +89,7 @@ enum platform_inst_fw_cap_type {
        CODED_FRAMES,
        BIT_DEPTH,
        RAP_FRAME,
-       DEBLOCK,
+       TIER,
        INST_FW_CAP_MAX,
 };
 
index 5c86fd7b7b6fd36dc2d57a1705d915308b4c0f92..543fa2661539188ee267838bc4742717b5b11204 100644 (file)
@@ -30,15 +30,6 @@ static struct platform_inst_fw_cap inst_fw_cap_sm8250[] = {
                .hfi_id = HFI_PROPERTY_PARAM_WORK_MODE,
                .set = iris_set_stage,
        },
-       {
-               .cap_id = DEBLOCK,
-               .min = 0,
-               .max = 1,
-               .step_or_mask = 1,
-               .value = 0,
-               .hfi_id = HFI_PROPERTY_CONFIG_VDEC_POST_LOOP_DEBLOCKER,
-               .set = iris_set_u32,
-       },
 };
 
 static struct platform_inst_caps platform_inst_cap_sm8250 = {