]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: enetc: Remove SI/BDR cacheability AXI settings for ENETC v4
authorClaudiu Manoil <claudiu.manoil@nxp.com>
Fri, 30 Jan 2026 14:10:32 +0000 (16:10 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 3 Feb 2026 02:11:52 +0000 (18:11 -0800)
For ENETC v4 these settings are controlled by the global ENETC
message and buffer cache attribute registers (EnBCAR and EnMCAR),
from the IERB register block.

The hardcoded cacheability settings were inherited from LS1028A,
and should be removed from the ENETC v4 driver as they conflict
with the global IERB settings.

Fixes: 99100d0d9922 ("net: enetc: add preliminary support for i.MX95 ENETC PF")
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Reviewed-by: Wei Fang <wei.fang@nxp.com>
Link: https://patch.msgid.link/20260130141035.272471-2-claudiu.manoil@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/enetc/enetc.c

index 53b26cece16a80959ceb138723b0d8d61f937327..e380a4f39855606963a81c12286b6c346f03e384 100644 (file)
@@ -2512,10 +2512,13 @@ int enetc_configure_si(struct enetc_ndev_priv *priv)
        struct enetc_hw *hw = &si->hw;
        int err;
 
-       /* set SI cache attributes */
-       enetc_wr(hw, ENETC_SICAR0,
-                ENETC_SICAR_RD_COHERENT | ENETC_SICAR_WR_COHERENT);
-       enetc_wr(hw, ENETC_SICAR1, ENETC_SICAR_MSI);
+       if (is_enetc_rev1(si)) {
+               /* set SI cache attributes */
+               enetc_wr(hw, ENETC_SICAR0,
+                        ENETC_SICAR_RD_COHERENT | ENETC_SICAR_WR_COHERENT);
+               enetc_wr(hw, ENETC_SICAR1, ENETC_SICAR_MSI);
+       }
+
        /* enable SI */
        enetc_wr(hw, ENETC_SIMR, ENETC_SIMR_EN);