]> git.ipfire.org Git - thirdparty/Chart.js.git/commitdiff
Fix memory leak on destroy (#8438)
authorJukka Kurkela <jukka.kurkela@gmail.com>
Tue, 16 Feb 2021 15:26:22 +0000 (17:26 +0200)
committerGitHub <noreply@github.com>
Tue, 16 Feb 2021 15:26:22 +0000 (10:26 -0500)
src/core/core.config.js
src/core/core.controller.js

index a0562faad5aea3a35e72048c283d6be330799300..309cf75fcba515458e810e0b32d311115b3c788c 100644 (file)
@@ -156,9 +156,13 @@ export default class Config {
 
   update(options) {
     const config = this._config;
+    this.clearCache();
+    config.options = initOptions(config, options);
+  }
+
+  clearCache() {
     this._scopeCache.clear();
     this._resolverCache.clear();
-    config.options = initOptions(config, options);
   }
 
   /**
index b84b22c33a60834115f2ac80ee8bc3ada2bb0dc7..3e9151a0ff61633636913e232269cff21f7927bd 100644 (file)
@@ -831,6 +831,8 @@ class Chart {
       me._destroyDatasetMeta(i);
     }
 
+    me.config.clearCache();
+
     if (canvas) {
       me.unbindEvents();
       clearCanvas(canvas, ctx);