]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: page_pool: don't cast mp param to devmem
authorPavel Begunkov <asml.silence@gmail.com>
Tue, 4 Feb 2025 21:56:12 +0000 (13:56 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 20 Apr 2025 08:15:17 +0000 (10:15 +0200)
[ Upstream commit 8d522566ae9cb3f0609ddb2a6ce3f4f39988043c ]

page_pool_check_memory_provider() is a generic path and shouldn't assume
anything about the actual type of the memory provider argument. It's
fine while devmem is the only provider, but cast away the devmem
specific binding types to avoid confusion.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: David Wei <dw@davidwei.uk>
Link: https://patch.msgid.link/20250204215622.695511-2-dw@davidwei.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/page_pool_user.c

index 48335766c1bfd61dda6559748ea3c02380518570..8d31c71bea1a39b07ac193d458fea1dbf9ed3d1a 100644 (file)
@@ -353,7 +353,7 @@ void page_pool_unlist(struct page_pool *pool)
 int page_pool_check_memory_provider(struct net_device *dev,
                                    struct netdev_rx_queue *rxq)
 {
-       struct net_devmem_dmabuf_binding *binding = rxq->mp_params.mp_priv;
+       void *binding = rxq->mp_params.mp_priv;
        struct page_pool *pool;
        struct hlist_node *n;