]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Remove a redundant log message and a comment
authorAram Sargsyan <aram@isc.org>
Mon, 25 Mar 2024 14:20:24 +0000 (14:20 +0000)
committerAram Sargsyan <aram@isc.org>
Tue, 2 Apr 2024 10:34:31 +0000 (10:34 +0000)
If val->result is not ISC_R_SUCCESS, a similar message is logged
further down in the function. Remove the redundant log message.

Also remove an unnecessary code comment line.

lib/dns/validator.c

index 5681c89a367408b92b34301bf632f6b1c333ed80..d80c22b04cf14756c0e634096b7ec267bdd492d4 100644 (file)
@@ -1638,11 +1638,7 @@ validate_answer_finish(void *arg) {
        dns_validator_t *val = arg;
        isc_result_t result = ISC_R_UNSET;
 
-       if (val->result != ISC_R_SUCCESS) {
-               validator_log(val, ISC_LOG_DEBUG(3),
-                             "failed to verify rdataset: %s",
-                             isc_result_totext(val->result));
-       } else {
+       if (val->result == ISC_R_SUCCESS) {
                dns_rdataset_trimttl(val->rdataset, val->sigrdataset,
                                     val->siginfo, val->start,
                                     val->view->acceptexpired);
@@ -1659,7 +1655,6 @@ validate_answer_finish(void *arg) {
 
        switch (val->result) {
        case ISC_R_CANCELED:
-               /* The validation was canceled */
                validator_log(val, ISC_LOG_DEBUG(3), "validation was canceled");
                validate_async_done(val, val->result);
                return;