review change.

git-svn-id: file:///svn/unbound/trunk@541 be551aaa-1e26-0410-a405-d3ace91eadb9

diff --git a/doc/Changelog b/doc/Changelog
index af092a88eb25950f2cf867de981ca25a6c7b1223..7eda8301a46877b2dc7a793ca8dba3036094a3e3 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,5 +1,6 @@
 22 August 2007: Wouter
        - bogus TTL.
+       - review - use val_error().
 
 21 August 2007: Wouter
        - ANY response validation.

diff --git a/validator/validator.c b/validator/validator.c
index d16465cb2bd80c83cd5a090c070ac3fb6143f146..e24324962dfb64a69305c72c020a9fc69a4e36f8 100644 (file)
--- a/validator/validator.c
+++ b/validator/validator.c
@@ -800,8 +800,7 @@ processFindKey(struct module_qstate* qstate, struct val_qstate* vq, int id)
                if(!generate_request(qstate, id, target_key_name, 
                        target_key_len, LDNS_RR_TYPE_DS, vq->qchase.qclass)) {
                        log_err("mem error generating DS request");
-                       qstate->ext_state[id] = module_error;
-                       return 0;
+                       return val_error(qstate, id);
                }
                return 0;
        }
@@ -811,8 +810,7 @@ processFindKey(struct module_qstate* qstate, struct val_qstate* vq, int id)
                vq->ds_rrset->rk.dname_len, LDNS_RR_TYPE_DNSKEY, 
                vq->qchase.qclass)) {
                log_err("mem error generating DNSKEY request");
-               qstate->ext_state[id] = module_error;
-               return 0;
+               return val_error(qstate, id);
        }
 
        return 0;
@@ -841,8 +839,7 @@ processValidate(struct module_qstate* qstate, struct val_qstate* vq,
 
        if(!vq->key_entry) {
                verbose(VERB_ALGO, "validate: no key entry, failed");
-               qstate->ext_state[id] = module_error;
-               return 0;
+               return val_error(qstate, id);
        }
 
        /* This is the default next state. */