]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
staging: gpib: fix unset padding field copy back to userspace
authorColin Ian King <colin.i.king@gmail.com>
Mon, 23 Jun 2025 22:09:58 +0000 (23:09 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 30 Jun 2025 17:13:54 +0000 (19:13 +0200)
The introduction of a padding field in the gpib_board_info_ioctl is
showing up as initialized data on the stack frame being copyied back
to userspace in function board_info_ioctl. The simplest fix is to
initialize the entire struct to zero to ensure all unassigned padding
fields are zero'd before being copied back to userspace.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Fixes: 9dde4559e939 ("staging: gpib: Add GPIB common core driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20250623220958.280424-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/common/gpib_os.c

index a193d64db0337e810720b151b184df126134dd63..93ef5f6ce249c2c27b186649a3ad11d0b7a754e3 100644 (file)
@@ -1774,7 +1774,7 @@ static int query_board_rsv_ioctl(struct gpib_board *board, unsigned long arg)
 
 static int board_info_ioctl(const struct gpib_board *board, unsigned long arg)
 {
-       struct gpib_board_info_ioctl info;
+       struct gpib_board_info_ioctl info = { };
        int retval;
 
        info.pad = board->pad;