Fix leak in build_argv() on line parsing error

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>

diff --git a/src/ipset.c b/src/ipset.c
index ce1b73f51633cc0e093ae9fea8752946749d0131..14a351a125f24162fae6c408fde4536bb643d5ae 100644 (file)
--- a/src/ipset.c
+++ b/src/ipset.c
@@ -176,7 +176,7 @@ build_argv(char *buffer)
                if ((newargc + 1) == (int)(sizeof(newargv)/sizeof(char *))) {
                        exit_error(PARAMETER_PROBLEM,
                                   "Line is too long to parse.");
-                       return;
+                       goto out;
                }
                switch (*tmp) {
                case '"':
@@ -200,7 +200,7 @@ build_argv(char *buffer)
                }
                if (!*(tmp+1) && quoted) {
                        exit_error(PARAMETER_PROBLEM, "Missing close quote!");
-                       return;
+                       goto out;
                }
                if (!*arg)
                        continue;
@@ -209,6 +209,7 @@ build_argv(char *buffer)
                memset(arg, 0, strlen(arg) + 1);
                i = 0;
        }
+out:
        free(arg);
 }