]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: ti: knav_qmss: Remove remaining redundant ENOMEM printks
authorNishanth Menon <nm@ti.com>
Tue, 12 May 2026 17:06:13 +0000 (12:06 -0500)
committerNishanth Menon <nm@ti.com>
Fri, 22 May 2026 15:55:55 +0000 (10:55 -0500)
Commit 168d2fb78055 ("soc: ti: knav_qmss: Remove ENOMEM printks")
removed redundant dev_err() calls after allocation failures in
knav_queue_setup_regions, knav_queue_init_qmgrs and
knav_queue_init_pdsps, but missed three further instances in
knav_pool_create, knav_queue_setup_region and knav_setup_queue_range.

Remove the missed instances.

Reviewed-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>
Link: https://patch.msgid.link/20260512170623.3174416-2-nm@ti.com
Signed-off-by: Nishanth Menon <nm@ti.com>
drivers/soc/ti/knav_qmss_queue.c

index a0644578789f5ace03742304dc8428c471028740..c5669a3713127b52ecd47b5e2fb8b19703574460 100644 (file)
@@ -769,10 +769,8 @@ void *knav_pool_create(const char *name,
                return ERR_PTR(-ENODEV);
 
        pool = devm_kzalloc(kdev->dev, sizeof(*pool), GFP_KERNEL);
-       if (!pool) {
-               dev_err(kdev->dev, "out of memory allocating pool\n");
+       if (!pool)
                return ERR_PTR(-ENOMEM);
-       }
 
        for_each_region(kdev, reg_itr) {
                if (reg_itr->id != region_id)
@@ -1025,10 +1023,8 @@ static void knav_queue_setup_region(struct knav_device *kdev,
        region->dma_end = region->dma_start + size;
 
        pool = devm_kzalloc(kdev->dev, sizeof(*pool), GFP_KERNEL);
-       if (!pool) {
-               dev_err(kdev->dev, "out of memory allocating dummy pool\n");
+       if (!pool)
                goto fail;
-       }
        pool->num_desc = 0;
        pool->region_offset = region->num_desc;
        list_add(&pool->region_inst, &region->pools);
@@ -1211,10 +1207,8 @@ static int knav_setup_queue_range(struct knav_device *kdev,
        int ret, i;
 
        range = devm_kzalloc(dev, sizeof(*range), GFP_KERNEL);
-       if (!range) {
-               dev_err(dev, "out of memory allocating range\n");
+       if (!range)
                return -ENOMEM;
-       }
 
        range->kdev = kdev;
        range->name = knav_queue_find_name(node);