clarify a deficiency in our packet hashing in the presence of EDNS subnet options

diff --git a/pdns/recpacketcache.cc b/pdns/recpacketcache.cc
index 68a4f3640dc4ea2085f429550b6140d1563f1197..73756cd8e1527c229112be31daecdf30687eff69 100644 (file)
--- a/pdns/recpacketcache.cc
+++ b/pdns/recpacketcache.cc
@@ -47,7 +47,7 @@ static bool qrMatch(const std::string& query, const std::string& response)
   uint16_t rqtype, rqclass, qqtype, qqclass;
   DNSName queryname(query.c_str(), query.length(), sizeof(dnsheader), false, &qqtype, &qqclass, 0);
   DNSName respname(response.c_str(), response.length(), sizeof(dnsheader), false, &rqtype, &rqclass, 0);
-  
+  // this ignores checking on the EDNS subnet flags! 
   return queryname==respname && rqtype == qqtype && rqclass == qqclass;
 }