]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: megaraid_sas: Return SCSI_MLQUEUE_HOST_BUSY instead of 1
authorBart Van Assche <bvanassche@acm.org>
Thu, 15 Jan 2026 21:03:39 +0000 (13:03 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 24 Jan 2026 02:32:34 +0000 (21:32 -0500)
.queuecommand() implementations are expected to return a SCSI_MLQUEUE_*
value. Return SCSI_MLQUEUE_HOST_BUSY from megaraid_queue_command_lck()
instead of 1. This patch doesn't change any functionality since
scsi_dispatch_cmd() converts all return values other than SCSI_MLQUEUE_*
into SCSI_MLQUEUE_HOST_BUSY.

Cc: Kashyap Desai <kashyap.desai@broadcom.com>
Cc: Sumit Saxena <sumit.saxena@broadcom.com>
Cc: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Cc: Chandrakanth patil <chandrakanth.patil@broadcom.com>
Cc: megaraidlinux.pdl@broadcom.com
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20260115210357.2501991-4-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_mbox.c

index b610cad83321dc719cc4303cf6249d44752342c7..722d3b5acea3658cf1199367305385cd9089c606 100644 (file)
@@ -1516,7 +1516,7 @@ megaraid_mbox_build_cmd(adapter_t *adapter, struct scsi_cmnd *scp, int *busy)
 
                        if (!(scb = megaraid_alloc_scb(adapter, scp))) {
                                scp->result = (DID_ERROR << 16);
-                               *busy = 1;
+                               *busy = SCSI_MLQUEUE_HOST_BUSY;
                                return NULL;
                        }
 
@@ -1599,7 +1599,7 @@ megaraid_mbox_build_cmd(adapter_t *adapter, struct scsi_cmnd *scp, int *busy)
                        /* Allocate a SCB and initialize passthru */
                        if (!(scb = megaraid_alloc_scb(adapter, scp))) {
                                scp->result = (DID_ERROR << 16);
-                               *busy = 1;
+                               *busy = SCSI_MLQUEUE_HOST_BUSY;
                                return NULL;
                        }
 
@@ -1644,7 +1644,7 @@ megaraid_mbox_build_cmd(adapter_t *adapter, struct scsi_cmnd *scp, int *busy)
                         */
                        if (!(scb = megaraid_alloc_scb(adapter, scp))) {
                                scp->result = (DID_ERROR << 16);
-                               *busy = 1;
+                               *busy = SCSI_MLQUEUE_HOST_BUSY;
                                return NULL;
                        }
                        ccb                     = (mbox_ccb_t *)scb->ccb;
@@ -1740,7 +1740,7 @@ megaraid_mbox_build_cmd(adapter_t *adapter, struct scsi_cmnd *scp, int *busy)
                         */
                        if (!(scb = megaraid_alloc_scb(adapter, scp))) {
                                scp->result = (DID_ERROR << 16);
-                               *busy = 1;
+                               *busy = SCSI_MLQUEUE_HOST_BUSY;
                                return NULL;
                        }
 
@@ -1808,7 +1808,7 @@ megaraid_mbox_build_cmd(adapter_t *adapter, struct scsi_cmnd *scp, int *busy)
                // Allocate a SCB and initialize passthru
                if (!(scb = megaraid_alloc_scb(adapter, scp))) {
                        scp->result = (DID_ERROR << 16);
-                       *busy = 1;
+                       *busy = SCSI_MLQUEUE_HOST_BUSY;
                        return NULL;
                }