]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: stmmac: rk: group MACPHY register offset and fields together
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Mon, 26 Jan 2026 11:45:18 +0000 (11:45 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 27 Jan 2026 18:40:06 +0000 (10:40 -0800)
Group the MACPHY register offsets and associated bitfields together
to become self-documenting which definitions are associated with
which register.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1vkL1y-00000005usW-1TKX@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c

index c8b49ed2064a33aef759221a3aa4e56389e57e8e..5f8d2031b97cc46695f3d944dd5bf5f005461850 100644 (file)
@@ -162,15 +162,17 @@ static int rk_set_clk_mac_speed(struct rk_priv_data *bsp_priv,
         ((rx) ? soc##_GMAC_RXCLK_DLY_ENABLE : soc##_GMAC_RXCLK_DLY_DISABLE))
 
 #define RK_GRF_MACPHY_CON0             0xb00
-#define RK_GRF_MACPHY_CON1             0xb04
-#define RK_GRF_MACPHY_CON2             0xb08
-#define RK_GRF_MACPHY_CON3             0xb0c
-
 #define RK_MACPHY_ENABLE               GRF_BIT(0)
 #define RK_MACPHY_DISABLE              GRF_CLR_BIT(0)
 #define RK_MACPHY_CFG_CLK_50M          GRF_BIT(14)
 #define RK_GMAC2PHY_RMII_MODE          GRF_FIELD(7, 6, 1)
+
+#define RK_GRF_MACPHY_CON1             0xb04
+
+#define RK_GRF_MACPHY_CON2             0xb08
 #define RK_GRF_CON2_MACPHY_ID          GRF_FIELD(15, 0, 0x1234)
+
+#define RK_GRF_MACPHY_CON3             0xb0c
 #define RK_GRF_CON3_MACPHY_ID          GRF_FIELD(5, 0, 0x35)
 
 static void rk_gmac_integrated_ephy_powerup(struct rk_priv_data *priv)