libcli/security: create_descriptor handles unknown ACE types

Because we're going to add more ACE types.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/libcli/security/create_descriptor.c b/libcli/security/create_descriptor.c
index aeb3ea3d3bb518ae383dd8bfa0a91c2dd26678c9..ab304a59a1cce2777533f182ee8a900aa97f4a84 100644 (file)
--- a/libcli/security/create_descriptor.c
+++ b/libcli/security/create_descriptor.c
@@ -215,6 +215,11 @@ static struct security_acl *calculate_inherited_from_parent(TALLOC_CTX *mem_ctx,
                        }
 
                        break;
+
+               default:
+                       DBG_WARNING("ACE type %d is not handled\n", ace->type);
+                       TALLOC_FREE(tmp_acl);
+                       return NULL;
                }
 
                if (ace->flags & SEC_ACE_FLAG_NO_PROPAGATE_INHERIT) {
@@ -327,6 +332,9 @@ static struct security_acl *calculate_inherited_from_parent(TALLOC_CTX *mem_ctx,
                                case SEC_ACE_TYPE_SYSTEM_AUDIT_OBJECT:
                                        tmp_ace->type = SEC_ACE_TYPE_SYSTEM_AUDIT;
                                        break;
+                                default:
+                                        /* all the _CALLBACK types */
+                                        break;
                                }
                        }