]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect/alert: use tx id in alert if frame has it
authorJuliana Fajardini <jufajardini@gmail.com>
Tue, 26 Apr 2022 14:57:49 +0000 (11:57 -0300)
committerVictor Julien <vjulien@oisf.net>
Sat, 30 Apr 2022 05:58:39 +0000 (07:58 +0200)
Task #4943

src/detect.c

index 57a2316d5890265da851d5d343f84e28d16692aa..3feac39f3b3c3e0a7e3c044ceb9ff65765db8b45 100644 (file)
@@ -1632,13 +1632,11 @@ static void DetectRunFrames(ThreadVars *tv, DetectEngineCtx *de_ctx, DetectEngin
 
                     const uint8_t alert_flags =
                             (PACKET_ALERT_FLAG_STATE_MATCH | PACKET_ALERT_FLAG_FRAME);
-                    // TODO set tx id if the frame has it
                     det_ctx->flags |= DETECT_ENGINE_THREAD_CTX_FRAME_ID_SET;
                     det_ctx->frame_id = frame->id;
                     SCLogDebug(
                             "%p/%" PRIi64 " sig %u (%u) matched", frame, frame->id, s->id, s->num);
-                    // TODO tx id frame field
-                    AlertQueueAppend(det_ctx, s, p, 0, alert_flags);
+                    AlertQueueAppend(det_ctx, s, p, frame->tx_id, alert_flags);
                 }
             }
             DetectVarProcessList(det_ctx, p->flow, p);