test: check if non-root user can access test directory

diff --git a/test/system/test.common b/test/system/test.common
index 9151e100c3250e9612698821cc3739b7c9e993e0..5b142c7e8d826ab068f2e89fed91c7fd2cbd86da 100644 (file)
--- a/test/system/test.common
+++ b/test/system/test.common
@@ -19,10 +19,20 @@ export TEST_DIR=${TEST_DIR:-$(pwd)/tmp}
 
 test_start() {
        check_chronyd_features NTP CMDMON || test_skip "NTP/CMDMON support disabled"
-       id -u "$user" > /dev/null 2> /dev/null || test_skip "missing user $user"
-       mkdir -p "$TEST_DIR" && chmod 700 "$TEST_DIR" && chown "$user:$(id -g "$user")" "$TEST_DIR" || \
-               test_skip "could not create $TEST_DIR"
-       rm -f "$TEST_DIR"/*
+
+       [ "${#TEST_DIR}" -ge 5 ] || test_skip "invalid TEST_DIR"
+
+       rm -rf "$TEST_DIR"
+       mkdir -p "$TEST_DIR" && chmod 700 "$TEST_DIR" || test_skip "could not create $TEST_DIR"
+
+       if [ "$user" != "root" ]; then
+               id -u "$user" > /dev/null 2> /dev/null || test_skip "missing user $user"
+               chown "$user:$(id -g "$user")" "$TEST_DIR" || test_skip "could not chown $TEST_DIR"
+               su "$user" -s /bin/bash -c "touch $TEST_DIR/test" 2> /dev/null || \
+                       test_skip "$user cannot access $TEST_DIR"
+               rm "$TEST_DIR/test"
+       fi
+
        echo "Testing $*:"
 }