]> git.ipfire.org Git - thirdparty/tornado.git/commitdiff
Remove obsolete param 'streaming' in BaseIOStream._finish_read()
authorlaggardkernel <laggardkernel@gmail.com>
Wed, 8 Dec 2021 10:55:18 +0000 (18:55 +0800)
committerlaggardkernel <laggardkernel@gmail.com>
Wed, 8 Dec 2021 10:55:18 +0000 (18:55 +0800)
Parameter 'streaming' has been obsolete since a55c7fe7 in 2018-07
when `_run_read_callback()` was renamed to `_finish_read()`.
This param should be removed as well after the removal of callback
in IOStream.

tornado/iostream.py

index 930f73d61aa31dbe5735a43165c2a0ecc4a64d27..34da8a2fdcac39526fb5719677a634b54dd329f5 100644 (file)
@@ -497,7 +497,7 @@ class BaseIOStream(object):
         """
         future = self._start_read()
         if self.closed():
-            self._finish_read(self._read_buffer_size, False)
+            self._finish_read(self._read_buffer_size)
             return future
         self._read_until_close = True
         try:
@@ -595,7 +595,7 @@ class BaseIOStream(object):
                         self.error = exc_info[1]
             if self._read_until_close:
                 self._read_until_close = False
-                self._finish_read(self._read_buffer_size, False)
+                self._finish_read(self._read_buffer_size)
             elif self._read_future is not None:
                 # resolve reads that are pending and ready to complete
                 try:
@@ -812,7 +812,7 @@ class BaseIOStream(object):
         self._read_future = Future()
         return self._read_future
 
-    def _finish_read(self, size: int, streaming: bool) -> None:
+    def _finish_read(self, size: int) -> None:
         if self._user_read_buffer:
             self._read_buffer = self._after_user_read_buffer or bytearray()
             self._after_user_read_buffer = None
@@ -904,7 +904,7 @@ class BaseIOStream(object):
         """
         self._read_bytes = self._read_delimiter = self._read_regex = None
         self._read_partial = False
-        self._finish_read(pos, False)
+        self._finish_read(pos)
 
     def _find_read_pos(self) -> Optional[int]:
         """Attempts to find a position in the read buffer that satisfies