Documentation updates

diff --git a/doc/man/man5/lloadd.conf.5 b/doc/man/man5/lloadd.conf.5
index 4392d53f40a02af6c5ef5f1453e94465e242f144..7b408c10c4bccfc996d2cd9f51a3b920c3445df9 100644 (file)
--- a/doc/man/man5/lloadd.conf.5
+++ b/doc/man/man5/lloadd.conf.5
@@ -278,6 +278,14 @@ The default is 16; the minimum value is 2.
 Specify the number of work queues to use for the primary thread pool.
 The default is 1 and this is typically adequate for up to 8 CPU cores.
 The value should not exceed the number of CPUs in the system.
+.TP
+.B max_pdus_per_cycle <integer>
+If set to 0, PDUs are handled by the I/O threads directly, otherwise
+a task is queued to be picked up by the thread pool. This task will
+process PDUs from the connection until there is no more data to be
+read or this limit is reached when the I/O thread can pick it up again.
+Very high values have a potential to cause some connections to be
+starved in a very high-bandwidth environment.
 
 .SH TLS OPTIONS
 If

diff --git a/servers/lloadd/upstream.c b/servers/lloadd/upstream.c
index 9cc551da32407a2130b0eb396a2f618f8442d90d..c632ab080f4514cd4675d060924e759786fc5b1f 100644 (file)
--- a/servers/lloadd/upstream.c
+++ b/servers/lloadd/upstream.c
@@ -311,6 +311,11 @@ handle_unsolicited( Connection *c, BerElement *ber )
  * TODO: when the client already has data pending on write, we should mute the
  * upstream.
  * - should record the BerElement on the Op and the Op on the client
+ *
+ * The following hold on entering any of the handlers:
+ * - op->o_upstream_refcnt > 0
+ * - op->o_upstream->c_refcnt > 0
+ * - op->o_client->c_refcnt > 0
  */
 static int
 handle_one_response( Connection *c )